Hi Vipin,
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:26 PM
> To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>; Wu, Jingjing
> <jingjing...@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 07/20] net/ice: support MTU setting
>
> snipped
> > +static int
> > +ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) {
> > + struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data-
> >dev_private);
> > + struct rte_eth_dev_data *dev_data = pf->dev_data;
> > + uint32_t frame_size = mtu + ETHER_HDR_LEN
> > + + ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE;
>
> Should this be ' ICE_VLAN_TAG_SIZE' or ' ICE_SWITCH_VLAN_TAG_SIZE'?
Don't get it. What should be changed?
> snipped
