On 04-Dec-18 5:06 PM, Seth Howell wrote:
When secondary process hotplugs memory, it sends a request
to primary, which then performs the real mmap() and sends
sync requests to all secondary processes. Upon receiving
such sync request, each secondary process will notify the
upper layers of hotplugged memory (and will call all
locally registered event callbacks).
In the end we'll end up with memory event callbacks fired
in all the processes except the primary, which is a bug.
This gets critical if memory is hotplugged while a VFIO
device is attached, as the VFIO memory registration -
which is done from a memory event callback present in the
primary process only - is never called.
After this patch, a primary process fires memory event
callbacks before secondary processes start their
synchronizations - both for hotplug and hotremove.
Change-Id: I60de33913f58bc2454069c3844826c92cb043fff
This is internal tag, please don't include it in the patch. Also, misses
Fixes: tag, and Cc: sta...@dpdk.org (since this bug goes back to 18.05).
Signed-off-by: Seth Howell <seth.how...@intel.com>
Signed-off-by: Darek Stojaczyk <dariusz.stojac...@intel.com>
---
Otherwise,
Reviewed-by: Anatoly Burakov <anatoly.bura...@intel.com>
--
Thanks,
Anatoly
