Do you plan to check for all iteration for ' flows->last_cmplt ' is successful?
> -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Varghese, Vipin > Sent: Wednesday, December 5, 2018 10:07 AM > To: Yang, Qiming <qiming.y...@intel.com>; dev@dpdk.org > Cc: Yang, Qiming <qiming.y...@intel.com>; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib: add warning for NULL pointer > > Hi, > > Should not the warning be stated for ' alloc_completion' failure > > Snipped > > > flows->num_packets * flows->categories); > > } > > > > + if (flows->last_cmplt == NULL) > > + RTE_LOG(WARNING, MALLOC, "packet tries allocate > > failed"); > > Why is that we want to try this outside block? > > > + > > /* set completion parameters and starting index for this slot */ > > parms[n].cmplt = flows->last_cmplt; > > transition = > > -- > > 2.9.5
