On Fri, 30 Nov 2018 22:47:50 +0300 Igor Ryzhov <iryz...@nfware.com> wrote:
> Current implementation of kni_ethtool_ops just uses corresponding > ethtool_ops function of underlying driver for all functions except for > .get_link. This commit sets kni->net_dev->ethtool_ops directly to the > ethtool_ops of the corresponding driver. > > For unknown drivers (all but ixgbe and i40e) we still use > kni_ethtool_ops with implemented .get_link function. > > Signed-off-by: Igor Ryzhov <iryz...@nfware.com> Why does KNI still support ethtool which: 1. Only works on a subset of devices 2. Requires a 3rd implmentation of the HW device (Linux, DPDK, and KNI) Then again why does KNI exist at all? What is missing from virtio user which is faster anyway.