On Wed, Nov 28, 2018 at 02:07:25PM +0100, David Marchand wrote: > On Wed, Nov 28, 2018 at 1:35 PM Neil Horman <nhor...@tuxdriver.com> wrote: > > > On Wed, Nov 28, 2018 at 11:28:52AM +0100, David Marchand wrote: > > > It does not hurt reporting the incriminated section. > > > > > > Before: > > > ERROR: symbol rte_meter_trtcm_rfc4115_color_aware_check is added in a > > > section other than the EXPERIMENTAL section of the version map > > > > > > After: > > > ERROR: symbol rte_meter_trtcm_rfc4115_color_aware_check is added in > > > +EXPERIMENTAL section other than the EXPERIMENTAL section of the > > > version map > > > > > nit: Its a bit odd in the changelog to have an example in which the > > incorect > > section being reported matches the expected section. I.e. its confusing > > to read > > "... is added in +EXPERIMENTAL section other than the EXPERIMENTAL > > section". > > Might be better to change the language of the report below and the example > > to be > > something like: > > > > ERROR: symbol <SYMBOL> is added in the <VERSION> section, but is expected > > to be > > added in the EXPERIMENTAL section > > > > ACK to the notion of reporting the offending section though. Thats a good > > idea. > > > > Ok, updated for v2. > Thanks! Neil
> -- > David Marchand
