28/11/2018 13:40, Eelco Chaudron: > > On 28 Nov 2018, at 11:09, Thomas Monjalon wrote: > > > 28/11/2018 10:27, Eelco Chaudron: > >> On 28 Nov 2018, at 9:38, David Marchand wrote: > >>> On Tue, Nov 27, 2018 at 4:22 PM Eelco Chaudron <echau...@redhat.com> > >>> wrote: > >>>> --- a/lib/librte_meter/Makefile > >>>> +++ b/lib/librte_meter/Makefile > >>>> -LIBABIVER := 2 > >>>> +LIBABIVER := 3 > >>> > >>> As far as I understood the policy around the EXPERIMENTAL section, > >>> you > >>> don't need to bump the library version. > >> > >> Thought I would add the new function as none experimental, i.e. next > >> version, but checkpatch did not allow me to do this. > >> > >> Tried to find info on what the right process was, as these functions > >> are > >> just another meter implementation using similar existing APIs. If > >> anyone > >> has any background on this please point me to it. > > > > It is documented here: > > http://doc.dpdk.org/guides/contributing/versioning.html > > > > The case for "similar API" is not handled specifically so far. > > So you need to introduce it as experimental. > > Thanks for the clarification, will update the APIs with > __rte_experimental in the next iteration.
You should also add this on top of the doxygen comment: * @warning * @b EXPERIMENTAL: this API may change without prior notice