> -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, November 9, 2018 2:14 PM > To: Zhang, Qi Z <qi.z.zh...@intel.com> > Cc: tho...@monjalon.net; dev@dpdk.org; Lin, Xueqin > <xueqin....@intel.com> > Subject: Re: [PATCH] net/pcap: enable data path on secondary > > On 11/5/2018 9:08 PM, Qi Zhang wrote: > > Private vdev on secondary is never supported by the new shared device > > mode but pdump still relies on a private pcap PMD on secondary. > > After your updates on hotplug multi process, isn't any virtual PMD added into > secondary will be added into primary too?
this becomes mandatory now, PMD have no choice. There is no "rte_dev_probe_local". > Is current pdump logic still valid after latest update? the requirement for PCAP PMD from pdump is, it need to support data path on secondary process, so the patch enable it. Btw, I just got validation result, seems the patch only works on PCAP file dump, it still have issue to dump packet to a netdev interface. So I want to hold this patch, I will submit a v2 to fix that issue. > > > The patch enables pcap PMD's data path on secondary so that pdump can > > work as usual. > > > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> >
