On 10/27/2018 11:40 AM, Xiaolong Ye wrote:
> Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
> to unexpected result, correct it by using a NOT-AND operation.
>
> Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads")
>
> Cc: harish.pa...@qlogic.com
> Cc: sta...@dpdk.org
> Signed-off-by: Xiaolong Ye <xiaolong...@intel.com>
> ---
> drivers/net/qede/qede_rxtx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/qede/qede_rxtx.h b/drivers/net/qede/qede_rxtx.h
> index d3a41e92e..9da059564 100644
> --- a/drivers/net/qede/qede_rxtx.h
> +++ b/drivers/net/qede/qede_rxtx.h
> @@ -159,7 +159,7 @@
> PKT_TX_TUNNEL_GRE)
>
> #define QEDE_TX_OFFLOAD_NOTSUP_MASK \
> - (PKT_TX_OFFLOAD_MASK ^ QEDE_TX_OFFLOAD_MASK)
> + ~(PKT_TX_OFFLOAD_MASK & QEDE_TX_OFFLOAD_MASK)
Hi Harish,
The qede usage can be problematic, because of how QEDE_TX_OFFLOAD_MASK set:
#define QEDE_TX_OFFLOAD_MASK (QEDE_TX_CSUM_OFFLOAD_MASK | \
PKT_TX_VLAN_PKT | \
PKT_TX_TUNNEL_VXLAN | \
PKT_TX_TUNNEL_GENEVE | \
PKT_TX_TUNNEL_MPLSINUDP | \
PKT_TX_TUNNEL_GRE)
I am not sure if OFFLOAD_NOTSUP_MASK works fine with multi-bit values, I think
you should set `PKT_TX_TUNNEL_MASK` here.
But please double check in case I am missing something.
