> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, October 28, 2018 6:27 PM > To: Zhang, Qi Z <qi.z.zh...@intel.com> > Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.bura...@intel.com>; Yigit, > Ferruh <ferruh.yi...@intel.com>; geoffrey...@gmail.com; > ajit.khapa...@broadcom.com; sta...@dpdk.org; gaetan.ri...@6wind.com; > arybche...@solarflare.com > Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix unexpected resource mapping > override > > 27/10/2018 05:20, Qi Zhang: > > When scanning an already plugged device, the virtual address of mapped > > PCI resource in rte_pci_device will be overridden with 0, that may > > cause driver does not work correctly. > > The fix is not to update any rte_pci_device's field if the being > > scanned device's driver is already probed. > > > > Bugzilla ID: 85 > > Fixes: c752998b5e2e ("pci: introduce library and driver") > > Cc: sta...@dpdk.org > > > > Reported-by: Lv Geoffrey <geoffrey...@gmail.com> > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> > > I still think something must be fixed in PCI scan.
We are fixing something in PCI scan, right? > > Anyway, there is an error: > passing argument 1 of ‘rte_dev_is_probed’ from incompatible pointer type So sorry, I should compile it first . > >