Hunt, David: > On 17/10/2018 12:43 PM, Thomas Monjalon wrote: > > 17/10/2018 13:23, David Hunt: > >> Signed-off-by: David Hunt <david.h...@intel.com> > >> --- > >> doc/guides/rel_notes/release_18_11.rst | 7 +++++++ > >> 1 file changed, 7 insertions(+) > > Why this patch is alone? It is for a change already applied? > > If you forgot the release notes, you should add a Fixes: line > > so we know which code change it refers. > > Thanks > > The related patch set is not merged yet, so I could not add a Fixes: line. > This is in reference to one of the patch sets I mentioned in an email to > you yesterday. > http://patches.dpdk.org/project/dpdk/list/?series=1628 > > > >> diff --git a/doc/guides/rel_notes/release_18_11.rst > >> b/doc/guides/rel_notes/release_18_11.rst > >> index 9c00e33cc..3174a0f80 100644 > >> --- a/doc/guides/rel_notes/release_18_11.rst > >> +++ b/doc/guides/rel_notes/release_18_11.rst > >> @@ -88,6 +88,13 @@ New Features > >> the specified port. The port must be stopped before the command call > >> in order > >> to reconfigure queues. > >> > >> +* **Added JSON power policy interface for containers .** > >> + > >> + Extended the Power Library and vm_power_manger sample app to allow power > >> + policies to be submitted via a FIFO using JSON formatted strings. > >> Previously > >> + limited to Virtual Machines, this feature extends power policy > >> functionality > >> + to containers and host applications that need to have their cores > >> frequency > >> + controlled based on the rules contained in the policy. > >> > >> API Changes > >> ----------- > > You must keep a double blank line before before next heading. > > > > Anyway you should move it before testpmd note, as explained in the comment: > > Suggested order in release notes items: > > * Core libs (EAL, mempool, ring, mbuf, buses) > > * Device abstraction libs and PMDs > > - ethdev (lib, PMDs) > > - cryptodev (lib, PMDs) > > - eventdev (lib, PMDs) > > - etc > > * Other libs > > * Apps, Examples, Tools (if significative) > > > > I can hold off uploading a v2 of this patch until the main patch set is > merged? Then I can > add in a Fixes: line and make your suggested changes.
In this case, it is a lot better to integrate it with one of the patches of your series, maybe with the doc patch?
