On 10/11/2018 7:13 PM, Akash Saxena wrote:
> Add tmp buffer to pass to OpenSSL sign API and memcmp output with
> original plain text to verify signature match.
> Set op->status = RTE_CRYPO_OP_STATUS_ERROR on signature mismatch.
>
> Signed-off-by: Ayuj Verma <ayuj.ve...@caviumnetworks.com>
> Signed-off-by: Akash Saxena <akash.sax...@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.ve...@caviumnetworks.com>
> ---
> drivers/crypto/openssl/rte_openssl_pmd.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
> b/drivers/crypto/openssl/rte_openssl_pmd.c
> index 003116d..cc33fca 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
> @@ -1843,6 +1843,9 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,
> struct rte_crypto_asym_op *op = cop->asym;
> RSA *rsa = sess->u.r.rsa;
> uint32_t pad = (op->rsa.pad);
> + uint8_t *tmp;
> +
> + cop->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
>
> switch (pad) {
> case RTE_CRYPTO_RSA_PKCS1_V1_5_BT0:
> @@ -1895,9 +1898,10 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,
> break;
>
> case RTE_CRYPTO_ASYM_OP_VERIFY:
> + tmp = rte_malloc(NULL, op->rsa.sign.length, 0);
> ret = RSA_public_decrypt(op->rsa.sign.length,
> op->rsa.sign.data,
> - op->rsa.sign.data,
> + tmp,
> rsa,
> pad);
Null checking of tmp is not done if rte_malloc fails. Please correct it.
>
> @@ -1905,13 +1909,15 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,
> "Length of public_decrypt %d "
> "length of message %zd\n",
> ret, op->rsa.message.length);
> -
> - if (memcmp(op->rsa.sign.data, op->rsa.message.data,
> - op->rsa.message.length)) {
> - OPENSSL_LOG(ERR,
> - "RSA sign Verification failed");
> - return -1;
> + if (ret > 0) {
> + if (memcmp(tmp, op->rsa.message.data,
> + op->rsa.message.length)) {
> + OPENSSL_LOG(ERR,
> + "RSA sign Verification failed");
> + cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
> + }
> }
> + rte_free(tmp);
> break;
>
> default:
