Hi Ferruh, Yes you are right about that, I missed adding it in the commit log Should I resend a new version with this noted?
Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@intel.com> > Sent: Thursday, October 11, 2018 7:20 PM > To: Raslan Darawsheh <rasl...@mellanox.com>; keith.wi...@intel.com > Cc: Thomas Monjalon <tho...@monjalon.net>; dev@dpdk.org; Shahaf > Shuler <shah...@mellanox.com>; Ori Kam <or...@mellanox.com>; > Alejandro Lucero <alejandro.luc...@netronome.com> > Subject: Re: [PATCH v6 2/3] net/tap: move fds of Rx/Tx queues to be in > process private > > On 10/10/2018 3:39 PM, Raslan Darawsheh wrote: > > fd's cannot be shared between processes, and each process need to have > > it's own fd's pointer. > > > > Signed-off-by: Raslan Darawsheh <rasl...@mellanox.com> > > --- > > drivers/net/tap/rte_eth_tap.c | 93 > > +++++++++++++++++++++++++++++-------------- > > drivers/net/tap/rte_eth_tap.h | 7 +++- > > drivers/net/tap/tap_flow.c | 3 +- > > drivers/net/tap/tap_intr.c | 5 ++- > > 4 files changed, 73 insertions(+), 35 deletions(-) > > > > diff --git a/drivers/net/tap/rte_eth_tap.c > > b/drivers/net/tap/rte_eth_tap.c index edfb7da..3372d54 100644 > > --- a/drivers/net/tap/rte_eth_tap.c > > +++ b/drivers/net/tap/rte_eth_tap.c > > @@ -315,6 +315,7 @@ static uint16_t > > pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > > { > > struct rx_queue *rxq = queue; > > + struct pmd_process_private *process_private; > > uint16_t num_rx; > > unsigned long num_rx_bytes = 0; > > uint32_t trigger = tap_trigger; > > @@ -323,6 +324,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf > **bufs, uint16_t nb_pkts) > > return 0; > > if (trigger) > > rxq->trigger_seen = trigger; > > + process_private = rte_eth_devices[rxq->in_port].process_private; > > This patch has a dependency to [1] which is waiting for new version, right? > Please note these kind of dependencies after "---" part of the commit log. > > [1] > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat > ches.dpdk.org%2Fpatch%2F46185%2F&data=02%7C01%7Crasland%40m > ellanox.com%7C5299b99a73e648ba870508d62f955870%7Ca652971c7d2e4d9b > a6a4d149256f461b%7C0%7C0%7C636748715807291110&sdata=lEbny%2F > gaGhBvfFlc8RzlB3YwvZ3uD43LCtq6w%2B07RFM%3D&reserved=0