04/10/2018 16:46, Jeff Guo: > --- a/doc/guides/rel_notes/release_18_08.rst > +++ b/doc/guides/rel_notes/release_18_08.rst > @@ -117,6 +117,11 @@ New Features > > Added support for chained mbufs (input and output). > > +* **Added hot-unplug handle mechanism.** > + > + ``rte_dev_hotplug_handle_enable`` and ``rte_dev_hotplug_handle_disable`` > are > + for enabling or disabling hotplug handle mechanism.
EAL features should be inserted before mbuf features. And more importantly, it should be inserted in 18.11 release notes ;) > --- a/lib/librte_eal/common/eal_private.h > +++ b/lib/librte_eal/common/eal_private.h > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice No need of experimental mark for internal functions. > + * > + * Register the sigbus handler. > + * > + * @return > + * - On success, zero. > + * - On failure, a negative value. > + */ > +int > +rte_dev_sigbus_handler_register(void); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Unregister the sigbus handler. > + * > + * @return > + * - On success, zero. > + * - On failure, a negative value. > + */ > +int > +rte_dev_sigbus_handler_unregister(void); Why are you using rte_ prefix for private functions?
