Ok, makes sense now, both flow query and flow list work with this patch, yeah.
Tested-by: John Daley <johnd...@cisco.com> Remember that https://patches.dpdk.org/patch/46221/ still needs to be reverted out of dpdk-next-net/master otherwise we are still broken. The patch was squished into e5b652ea34. -johnd > -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Mordechay Haimovsky > Sent: Wednesday, October 10, 2018 10:05 AM > To: Adrien Mazarguil <adrien.mazarg...@6wind.com>; Shahaf Shuler > <shah...@mellanox.com>; Ori Kam <or...@mellanox.com> > Cc: dev@dpdk.org; Mordechay Haimovsky <mo...@mellanox.com> > Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure > > This patch fixes a bug found in port_flow_query routine which caused flow > query command to fail with the following error "Caught error type 1 (cause > unspecified): unknown object type to retrieve the name > of: Invalid argument". > > Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function") > > Signed-off-by: Moti Haimovsky <mo...@mellanox.com> > --- > app/test-pmd/config.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 009c92c..b11317b 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1239,7 +1239,8 @@ void print_valid_ports(void) > return -ENOENT; > } > ret = rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR, > - &name, sizeof(name), action, &error); > + &name, sizeof(name), > + (void *)(uintptr_t)action->type, &error); > if (ret < 0) > return port_flow_complain(&error); > switch (action->type) { > -- > 1.8.3.1
