Hi, Just sent a new version with the commit log reworded to answer the "why" question you mentioned. Thx for your reviews.
Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Wednesday, October 10, 2018 5:08 PM > To: Wiles, Keith <keith.wi...@intel.com>; Raslan Darawsheh > <rasl...@mellanox.com> > Cc: dev@dpdk.org; Shahaf Shuler <shah...@mellanox.com>; Ori Kam > <or...@mellanox.com>; Yigit, Ferruh <ferruh.yi...@intel.com> > Subject: Re: [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues > structures > > 10/10/2018 14:50, Wiles, Keith: > > > > > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasl...@mellanox.com> > wrote: > > > > > > Signed-off-by: Raslan Darawsheh <rasl...@mellanox.com> > > > > This title for the patch is the what we did not why we did it, should that > > be > changed? To me it does not convey the reason or we would need to add a > more complete comment body text to explain why we wanted the change. It > is a bit of nit picking. > > I think the question "why" must be answered in the body. > >
