10/10/2018 11:05, Andrew Rybchenko: > On 10/10/18 11:53 AM, Thomas Monjalon wrote: > > 10/10/2018 09:51, Andrew Rybchenko: > >> The documentation says MAC addresses array is retained and > >> it is logical to assume that default MAC address is retained > >> as well. > > I'm confused. Default MAC address isn't implied by MAC addresses array? > > From API point of view it looks as different features (at least for me): > - default MAC address is rte_eth_dev_default_mac_addr_set() > - MAC addresses array is > rte_eth_dev_mac_addr_add()/rte_eth_dev_mac_addr_remove() > but it is under one umbrella in NIC features (Unicast MAC filter).
Because default MAC address is mac_addrs[0]. > May be it is my misunderstanding. More doc is better :) If it can be thought as different features, let's document it as you do.
