> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Saturday, October 6, 2018 9:16 AM
> To: Thomas Monjalon <tho...@monjalon.net>
> Cc: Yigit, Ferruh <ferruh.yi...@intel.com>; Andrew Rybchenko
> <arybche...@solarflare.com>; Lu, Wenzhuo <wenzhuo...@intel.com>; Wu,
> Jingjing <jingjing...@intel.com>; Iremonger, Bernard
> <bernard.iremon...@intel.com>; Mcnamara, John <john.mcnam...@intel.com>;
> Kovacevic, Marko <marko.kovace...@intel.com>; Olivier Matz
> <olivier.m...@6wind.com>; dev@dpdk.org; shah...@mellanox.com;
> Ananyev, Konstantin <konstantin.anan...@intel.com>; didier.pall...@6wind.com
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
> checksum definition
>
> -----Original Message-----
> > Date: Sat, 06 Oct 2018 00:44:52 +0200
> > From: Thomas Monjalon <tho...@monjalon.net>
> > To: Ferruh Yigit <ferruh.yi...@intel.com>, Jerin Jacob
> > <jerin.ja...@caviumnetworks.com>, Andrew Rybchenko
> > <arybche...@solarflare.com>
> > Cc: Wenzhuo Lu <wenzhuo...@intel.com>, Jingjing Wu <jingjing...@intel.com>,
> > Bernard Iremonger <bernard.iremon...@intel.com>, John McNamara
> > <john.mcnam...@intel.com>, Marko Kovacevic <marko.kovace...@intel.com>,
> > Olivier Matz <olivier.m...@6wind.com>, dev@dpdk.org, shah...@mellanox.com,
> > "Ananyev, Konstantin" <konstantin.anan...@intel.com>,
> > didier.pall...@6wind.com
> > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
> > checksum definition
> >
> >
> > 05/10/2018 22:04, Ferruh Yigit:
> > > On 10/4/2018 6:59 AM, Jerin Jacob wrote:
> > > > From: Andrew Rybchenko <arybche...@solarflare.com>
> > > >> On 03.10.2018 21:14, Jerin Jacob wrote:
> > > >>> From: Andrew Rybchenko <arybche...@solarflare.com>
> > > >>>> On 03.10.2018 20:12, Jerin Jacob wrote:
> > > >>>>> From: Jerin Jacob <jerin.ja...@caviumnetworks.com>
> > > >>>>>> From: Andrew Rybchenko <arybche...@solarflare.com>
> > > >>>>>>> 3. PKT_RX_L4_CKSUM_MASK description says nothing if it is inner
> > > >>>>>>> or outer.
> > > >>>>>>> May be it is not directly related to changeset, but I think
> > > >>>>>>> it would be really
> > > >>>>>>> useful to clarify it.
> > > >>>>>> I will update the comment.
> > > >>>>> Hi Andrew,
> > > >>>>>
> >
> > However, we should re-visit the flag PKT_RX_EIP_CKSUM_BAD.
>
> Do we need to block this patch due to the exiting PKT_RX_EIP_CKSUM_BAD
> definition?
>
> I already added the author of the PKT_RX_EIP_CKSUM_BAD flag and ethdev and
> mbuf
> maintainers in this list. So what else I need make forward progress
> on this patch?
>
> I think, the definition of PKT_RX_EIP_CKSUM_BAD based on HW capability. It
> is safe to assume that ALL HW can support CKSUM BAD if the feature is
> available and hence it is more portable.
Yes, as I remember PKT_RX_EIP_CKSUM_BAD is based on
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM.
Konstantin
>
> >
> >
