On Thu, Oct 04, 2018 at 06:10:12PM +0300, Ilya Maximets wrote: > On 04.10.2018 17:51, Ferruh Yigit wrote: > > On 10/4/2018 2:18 PM, Ilya Maximets wrote: > >> This functionality was missed while adding new drivers to > >> the meson build. > > > > Is there any call from base code to experimental APIs? What do you think > > adding > > this when we need it, since I have feeling that this may not be needed. > > The patch itself does not enable the experimental APIs, it only > adds the ability to enable them in the future. It's actually > pretty hard for the person that not much familiar with meson to > find out why your code provides deprecation warnings. I spent > few hours trying to make it work but failed. After that Bruce found > that 'base' code parts ignores 'allow_experimental_apis' flag and > prepared the patch. Thank you, Bruce! > This patch possibly will save a few hours for someone like me, who > will try to enable experimental APIs for avf and qede drivers. > > And I already need avf part for my patch set with nanosleep > based delay: > http://patches.dpdk.org/cover/46088/ > +1, I think it should be added, as it basically just is allowing passthrough of the flag to the base drivers.
/Bruce