01/10/2018 13:24, Andrew Rybchenko: > On 9/28/18 7:21 PM, Thomas Monjalon wrote: > > rte_eal_parse_devargs_str() does not support parsing the bus name > > at the start of devargs. So it has been renamed and deprecated. > > > > rte_eal_devargs_add(), rte_eal_devargs_type_count() and > > rte_eal_devargs_dump() were declared deprecated and had their > > implementation body renamed. > > > > All these functions were deprecated in release 18.05. > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > Reviewed-by: Andrew Rybchenko <arybche...@solarflare.com> > > I would say that it is more fair to say that changes related to > rte_eal_devargs_add(), rte_eal_devargs_type_count() and > rte_eal_devargs_dump() fixes b65ecf19 since the changeset > simply removes these functions. May be the ideal solution > is to add changeset which adds these deprecated functions > and simply calls replacement and remove in the next changeset. > But it is too many efforts for nothing, so good to go as is.
Yes, not worth the effort. > Should it be mentioned in release notes (API removal)? Yes, you're right, will add a note in v4. Thanks
