On 09/27/2018 08:05 PM, Kevin Traynor wrote:
On 09/27/2018 01:37 PM, Maxime Coquelin wrote:


On 09/27/2018 02:24 PM, Maxime Coquelin wrote:


On 09/17/2018 05:54 AM, Jiayu Hu wrote:
When perform enqueue operations on the split and packed ring,
s/perform/performing/
s/ring/rings/
if the reserved buffer length from the descriptor table execeeds
65535, the returned length by fill_vec_buf_split/_packed() is
overflowed. This patch is to avoid this corner case.
s/overflowed/overflows/

Fixes: f689586b ("vhost: shadow used ring update")
Fixes: fd68b473 ("vhost: use buffer vectors in dequeue path")
Fixes: 2f3225a7 ("vhost: add vector filling support for packed ring")
Fixes: 37f5e79a ("vhost: add shadow used ring support for packed rings")
Fixes: a922401f ("vhost: add Rx support for packed ring")
Fixes: ae999ce4 ("vhost: add Tx support for packed ring")


It breaks the record for number of Fixes? :-)

This is exhaustive! :)

I think relevant for stables also - any reason why not?

Forgot to mention, but I added it while applying.

FYI, it targets v18.08.

Signed-off-by: Jiayu Hu <jiayu...@intel.com>
---
   lib/librte_vhost/virtio_net.c | 20 +++++++++++---------
   1 file changed, 11 insertions(+), 9 deletions(-)


Other than that, the patch looks good to me. Thanks for fixing it.

Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>

Maxime

Applied to dpdk-next-virtio/master with commit message fix.

Thanks,
Maxime

Reply via email to