On 9/19/2018 4:14 PM, Gaëtan Rivet wrote: > On Fri, Aug 31, 2018 at 05:16:32PM +0100, Andrew Rybchenko wrote: >> From: Igor Romanov <igor.roma...@oktetlabs.ru> >> >> Releasing a queue that is already released by slave may cause a >> segmentation fault. For example, after a successfull device >> configuration a queue is set up. Afterwards the device is reconfigured >> with an invalid argument, forcing slaves to release the queues >> (e.g. rte_eth_dev.data.tx_queues). Finally the failsafe's queues >> are released. The queue release functions also try to release slaves' >> queues using ETH(sdev)->data->tx_queues which is NULL at the time. >> >> Add checks for NULL slaves' Tx and Rx queues before releasing them. >> >> Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Igor Romanov <igor.roma...@oktetlabs.ru> >> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com> > > Acked-by: Gaetan Rivet <gaetan.ri...@6wind.com>
Applied to dpdk-next-net/master, thanks.