Hi Thomas.
Beside your questions,
There is another patch that targeted to fix this issue:
http://patches.dpdk.org/patch/44020/
And one similar to mine that I missed while sending:
http://patches.dpdk.org/patch/43692/
So, I'm not sure which one should be accepted and if I need to
update my version. What do you think? Stephen? Andrzej?
Best regards, Ilya Maximets.
On 14.09.2018 17:50, Thomas Monjalon wrote:
> 16/08/2018 07:25, Arnon Warshavsky:
>> Hi Ilya
>>
>> Let's use single quotes instead of variable.
>>
>>
>> Using the script directly with single quotes loses the ability to reuse it
>> with an additional set of folders , expressions and RET_ON_FAIL.
>
> I don't know awk. Please could you explain what we are loosing and why?
>
>> If we wish to keep the awk code in this file and not in a separate file,
>> maybe receiving the awk script parameters from the function
>> check_forbidden_additions( ) can also preserve the ability to reuse in
>> future cases.
>
> Yes I feel we could add some parameters to this function.
> And yes, we could move the awk script in a separate file.
> Actually, it would be better to keep checkpatches.sh as a wrapper script
> calling various tools.
>
> Thanks
>
>
>
>
