On Mon, Sep 10, 2018 at 06:43:17PM +0200, Maxime Coquelin wrote: > Hi Ilya, > > On 09/10/2018 06:09 PM, Ilya Maximets wrote: > > Hi Maxime, > > Thanks for pointing to this patch set. I missed it somehow. > > > > This patch could not replace mine [1], because it does not improve > > the message handling from the error handling point of view. But > > it completely changes the code, so we need to negotiate the order > > in which they will be applied or combine them somehow. > > By complementary I meant both of your patches add similar things, like > vhost_user_set_vring_kick() becoming an int (even if Nikolay's version > doesn't return an error for now). > > > > > So, what's the plan? What do you think? > > On one hand Nikolay's series was posted first, and it might be easier to > just apply your patch on top. On the other hand, your patch fixes an > issue, so it will be easier to backport it if it is applied first. > > I guess we should go for your patch first to ease backporting. > > I'd like Tiwei's feedback before applying anything, as he reviewed the > first versions of both yours and Nikolay's patches.
I also incline to merge the fix patch first, as it needs to be backported. > > > Few comments inline. > > > > [1] http://patchwork.dpdk.org/patch/44168/ [...]
