Re: [dpdk-dev] [PATCH] ethdev: fix missing names in Tx offload name array

[Andrew Rybchenko]

On 09/06/2018 03:01 PM, Dekel Peled wrote:

Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx.
If new Tx offload capabilities are defined, they also must be mentioned
in rte_tx_offload_names in rte_ethdev.c file.

This patch adds the required lines in aray rte_tx_offload_names.

Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP tunnel checksum and TSO")

Cc: xuemi...@mellanox.com

Signed-off-by: Dekel Peled <dek...@mellanox.com>
---
  lib/librte_ethdev/rte_ethdev.c | 2 ++
  lib/librte_ethdev/rte_ethdev.h | 4 ++--
  2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 3f8de93..5004b9f 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -156,6 +156,8 @@ struct rte_eth_xstats_name_off {
        RTE_TX_OFFLOAD_BIT2STR(MULTI_SEGS),
        RTE_TX_OFFLOAD_BIT2STR(MBUF_FAST_FREE),
        RTE_TX_OFFLOAD_BIT2STR(SECURITY),
+       RTE_TX_OFFLOAD_BIT2STR(UDP_TNL_TSO),
+       RTE_TX_OFFLOAD_BIT2STR(IP_TNL_TSO),
  };

#undef RTE_TX_OFFLOAD_BIT2STR

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index fa2812b..5456ce2 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -941,18 +941,18 @@ struct rte_eth_conf {
   *   the same mempool and has refcnt = 1.
   */
  #define DEV_TX_OFFLOAD_SECURITY         0x00020000
+#define DEV_TX_OFFLOAD_UDP_TNL_TSO      0x00040000
  /**
   * Device supports generic UDP tunneled packet TSO.
   * Application must set PKT_TX_TUNNEL_UDP and other mbuf fields required
   * for tunnel TSO.
   */
-#define DEV_TX_OFFLOAD_UDP_TNL_TSO      0x00040000
+#define DEV_TX_OFFLOAD_IP_TNL_TSO       0x00080000
  /**
   * Device supports generic IP tunneled packet TSO.
   * Application must set PKT_TX_TUNNEL_IP and other mbuf fields required
   * for tunnel TSO.
   */
-#define DEV_TX_OFFLOAD_IP_TNL_TSO       0x00080000

I don't understand why it is changed. Comments should be before define.

#define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001

  /**< Device supports Rx queue setup after device started*/