On Mon, Sep 10, 2018 at 06:02:19AM +0000, Gavin Hu (Arm Technology China) wrote:
>
>
> > -----Original Message-----
> > From: dev <dev-boun...@dpdk.org> On Behalf Of Jens Freimann
> > Sent: Friday, September 7, 2018 2:20 AM
> > To: dev@dpdk.org
> > Cc: tiwei....@intel.com; maxime.coque...@redhat.com
> > Subject: [dpdk-dev] [PATCH v5 05/11] net/virtio: dump packed virtqueue
> > data
> >
> > Add support to dump packed virtqueue data to the
> > VIRTQUEUE_DUMP() macro.
> >
> > Signed-off-by: Jens Freimann <jfreim...@redhat.com>
>
> Acked-by: Gavin Hu <gavin...@arm.com>
>
> > ---
> > drivers/net/virtio/virtqueue.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> > index 53fce61b4..531ba8c65 100644
> > --- a/drivers/net/virtio/virtqueue.h
> > +++ b/drivers/net/virtio/virtqueue.h
> > @@ -384,6 +384,12 @@ virtqueue_notify(struct virtqueue *vq)
> > uint16_t used_idx, nused; \
> > used_idx = (vq)->vq_ring.used->idx; \
The vq_ring.used doesn't exist in packed ring.
> > nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \
The nused can't be calculated in this way in
packed ring.
> > +if (vtpci_packed_queue((vq)->hw)) { \
> > + PMD_INIT_LOG(DEBUG, \
> > + "VQ: - size=%d; free=%d; last_used_idx=%d;", \
> > + (vq)->vq_nentries, (vq)->vq_free_cnt, nused); \
And nused doesn't mean last_used_idx.
> > + break; \
> > +} \
> > PMD_INIT_LOG(DEBUG, \
> > "VQ: - size=%d; free=%d; used=%d; desc_head_idx=%d;" \
> > " avail.idx=%d; used_cons_idx=%d; used.idx=%d;" \
> > --
> > 2.17.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
