> -----Original Message-----
> From: Neil Horman [mailto:nhor...@tuxdriver.com]
> Sent: Wednesday, August 15, 2018 4:19 PM
> To: Rao, Nikhil <nikhil....@intel.com>
> Cc: dev@dpdk.org; tho...@monjalon.net; Mcnamara, John
> <john.mcnam...@intel.com>; Richardson, Bruce
> <bruce.richard...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com>;
> step...@networkplumber.org; toggle-mailboxes@hmswarspite.think-
> freely.org
> Subject: Re: [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition
>
>
>
> Thanks, I think I made a mistake in how I detect section names in the awk
> script. The rule assumes that the entire section is getting added (i.e. we
> are
> adding the EXPERIMENTAL section as a whole unit, hence the starting a line
> with
> + to id the section name, and thats not the case here. I think the rule
> + needs
> to be any line in a map file that ends with a { (based on our coding
> practice), is
> a section start, and the section name is the next to the last field in the
> line (i.e.
> $(NF-1) ). Please apply the patch below and confirm that this works for you.
>
> Best
> Neil
>
>
Thanks for the fix, it works.
Nikhil
>
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-
> change.sh index daaf45e14..cf9cfc745 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -25,14 +25,14 @@ build_map_changes()
> # supresses the subordonate rules below
> /[-+] a\/.*\.^(map)/ {in_map=0}
>
> - # Triggering this rule, which starts a line with a + and ends it
> + # Triggering this rule, which starts a line and ends it
> # with a { identifies a versioned section. The section name is
> # the rest of the line with the + and { symbols remvoed.
> # Triggering this rule sets in_sec to 1, which actives the
> # symbol rule below
> - /+.*{/ {gsub("+","");
> + /^.*{/ {
> if (in_map == 1) {
> - sec=$1; in_sec=1;
> + sec=$(NF-1); in_sec=1;
> }
> }
>
