Hi, I have fixed it, thanks.
> -----Original Message----- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Sunday, July 22, 2018 14:34 > To: Xu, Rosen <rosen...@intel.com>; dev@dpdk.org > Cc: Yigit, Ferruh <ferruh.yi...@intel.com>; Gilmore, Walter E > <walter.e.gilm...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; > sta...@dpdk.org > Subject: RE: [PATCH v2] examples/flow_filtering: add rte_fdir_conf > initialization > > > > > -----Original Message----- > > From: Rosen Xu [mailto:rosen...@intel.com] > > Sent: Saturday, July 21, 2018 10:50 AM > > To: dev@dpdk.org > > Cc: rosen...@intel.com; ferruh.yi...@intel.com; Ori Kam > > <or...@mellanox.com>; walter.e.gilm...@intel.com; > > qi.z.zh...@intel.com; sta...@dpdk.org > > Subject: [PATCH v2] examples/flow_filtering: add rte_fdir_conf > > initialization > > > > Rte_fdir_conf of rte_eth_conf should be initialized before port > > initialization. It is a workaround solution when work with Intel I40e. > > > > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow > > API") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Rosen Xu <rosen...@intel.com> > > > > v2 updates: > > =========== > > - Take more test on I40e > > - Add comments > > --- > > examples/flow_filtering/main.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/examples/flow_filtering/main.c > > b/examples/flow_filtering/main.c index f595034..73d646c 100644 > > --- a/examples/flow_filtering/main.c > > +++ b/examples/flow_filtering/main.c > > @@ -132,6 +132,17 @@ > > DEV_TX_OFFLOAD_SCTP_CKSUM | > > DEV_TX_OFFLOAD_TCP_TSO, > > }, > > + /* > > + * Initialize fdir_conf of ete_eth_conf > > + * it is a workaround solution when work with Intel I40e > > + * and it is not the normal way > > + */ > > + .fdir_conf = { > > + .mode = RTE_FDIR_MODE_PERFECT, > > + .pballoc = RTE_FDIR_PBALLOC_64K, > > + .status = RTE_FDIR_REPORT_STATUS, > > + .drop_queue = 127, > > + }, > > }; > > struct rte_eth_txconf txq_conf; > > struct rte_eth_rxconf rxq_conf; > > -- > > 1.8.3.1 > > Just small comment I think work should be replaced with working. > Both in the commit log and code comment. It's fixed. > Acked-by: Ori Kam <or...@mellanox.com> > > Thanks, > Ori
