Hi Pablo, On Fri, Jul 13, 2018 at 08:52:07AM +0000, De Lara Guarch, Pablo wrote: > Hi Nelio, > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro > > Sent: Friday, July 13, 2018 9:25 AM > > To: dev@dpdk.org; Thomas Monjalon <thom...@mellanox.com> > > Subject: [dpdk-dev] [PATCH] ethdev: fix missing function in map file > > > > Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows") > > > > Signed-off-by: Nelio Laranjeiro <nelio.laranje...@6wind.com> > > Acked-by: Adrien Mazarguil <adrien.mazarg...@6wind.com> > > --- > > lib/librte_ethdev/rte_ethdev_version.map | 1 + > > lib/librte_ethdev/rte_flow_driver.h | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_ethdev/rte_ethdev_version.map > > b/lib/librte_ethdev/rte_ethdev_version.map > > index 9a0d12d41..0af8731b6 100644 > > --- a/lib/librte_ethdev/rte_ethdev_version.map > > +++ b/lib/librte_ethdev/rte_ethdev_version.map > > @@ -251,4 +251,5 @@ EXPERIMENTAL { > > rte_mtr_policer_actions_update; > > rte_mtr_stats_read; > > rte_mtr_stats_update; > > + rte_flow_expand_rss; > > This list is in alphabetical order. > > }; > > diff --git a/lib/librte_ethdev/rte_flow_driver.h > > b/lib/librte_ethdev/rte_flow_driver.h > > index ca675f6d3..141d4acac 100644 > > --- a/lib/librte_ethdev/rte_flow_driver.h > > +++ b/lib/librte_ethdev/rte_flow_driver.h > > @@ -169,7 +169,7 @@ struct rte_flow_expand_rss { > > * > > * -E2BIG: graph-depth @p graph is too deep. > > */ > > -int > > +int __rte_experimental > > The implementation in the .c file should also have the experimental tag. > > > rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size, > > const struct rte_flow_item *pattern, uint64_t types, > > const struct rte_flow_expand_node graph[], > > --
Will fix both point in a v2. Thanks, -- Nélio Laranjeiro 6WIND
