Hi Jeff: > -----Original Message----- > From: Guo, Jia > Sent: Monday, July 9, 2018 7:46 PM > To: step...@networkplumber.org; Richardson, Bruce > <bruce.richard...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; > Ananyev, Konstantin <konstantin.anan...@intel.com>; > gaetan.ri...@6wind.com; Wu, Jingjing <jingjing...@intel.com>; > tho...@monjalon.net; mo...@mellanox.com; ma...@mellanox.com; Van > Haaren, Harry <harry.van.haa...@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; He, Shaopeng <shaopeng...@intel.com>; Iremonger, > Bernard <bernard.iremon...@intel.com>; arybche...@solarflare.com; Lu, > Wenzhuo <wenzhuo...@intel.com> > Cc: jblu...@infradead.org; shreyansh.j...@nxp.com; dev@dpdk.org; Guo, Jia > <jia....@intel.com>; Zhang, Helin <helin.zh...@intel.com> > Subject: [PATCH v3 1/4] ethdev: Add eal device event callback > > Implement a eal device event callback "rte_eth_dev_event_callback" > in ethdev, it could let pmd driver have chance to manage the eal device event, > such as process hotplug event. > > Signed-off-by: Jeff Guo <jia....@intel.com> > --- <...> > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Implement a rte eth eal device event callbacks for the specific device. > + * > + * @param device_name > + * Pointer to the name of the rte device. > + * @param event > + * Eal device event type. > + * @param ret_param > + * To pass data back to user application. > + * > + * @return > + * void > + */ > +void __rte_experimental > +rte_eth_dev_event_callback(char *device_name, > + enum rte_dev_event_type event, void *cb_arg);
I don't think we should expose the callback function to PMD directly It should be a function like rte_eth_dev_event_callback_register(struct rte_ethdev *dev) which looks more like an ethdev help API for drivers. And inside the function , we do the rte_dev_event_callback_register ... And rte_eth_dev_event_callback should be rename to eth_dev_event_callback as a static function. Regards Qi > + > +/** > * @internal Executes all the user application registered callbacks for > * the specific device. It is for DPDK internal user only. User > * application should not call it directly. > -- > 2.7.4
