Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add function for checking IOVAs by a device

[Andrew Rybchenko]

On 04.07.2018 15:53, Alejandro Lucero wrote:

A PMD should invoke this function for checking memsegs iovas are within
the supported range by the device.

Signed-off-by: Alejandro Lucero <alejandro.luc...@netronome.com>
---
  lib/librte_ether/rte_ethdev.h           | 13 +++++++++++++
  lib/librte_ether/rte_ethdev_version.map |  1 +
  2 files changed, 14 insertions(+)

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index eba11ca..e51a432 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -2799,6 +2799,19 @@ int rte_eth_dev_set_vlan_ether_type(uint16_t port_id,
  int rte_eth_dev_set_vlan_pvid(uint16_t port_id, uint16_t pvid, int on);

/**

+ * check device dma mask within expected range based on dma mask.
+ *
+ * @param maskbits
+ *  mask length in bits
+ *
+ */
+static inline int
+rte_eth_dev_check_dma_mask(uint8_t maskbits)
+{
+       return rte_eal_check_dma_mask(maskbits);

I'm afraid I don't understand why do we need the wrapper.
May PMD use EAL function directly?

+}
+
+/**
   *
   * Retrieve a burst of input packets from a receive queue of an Ethernet
   * device. The retrieved packets are stored in *rte_mbuf* structures whose
diff --git a/lib/librte_ether/rte_ethdev_version.map 
b/lib/librte_ether/rte_ethdev_version.map
index e9681ac..0b11b8a 100644
--- a/lib/librte_ether/rte_ethdev_version.map
+++ b/lib/librte_ether/rte_ethdev_version.map
@@ -191,6 +191,7 @@ DPDK_17.08 {
  DPDK_17.11 {
        global:

+ rte_eth_dev_check_dma_mask;

        rte_eth_dev_get_sec_ctx;
        rte_eth_dev_pool_ops_supported;
        rte_eth_dev_reset;