On Wednesday 04 July 2018 03:13 PM, Hemant Agrawal wrote:
This patch fix the prefetch rx routine to
^^^^^
fixes
set the next prefetch request to the size of nb_pkts.
This will assume that next request will ideally will be
of same size.
Incorrect wording.
Maybe:
"It assumes that next request would ideally be of same size"
Fixes: 4bc5ab88dbd6 ("net/dpaa2: fix Tx only mode")
Cc: sta...@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com>
---
drivers/net/dpaa2/dpaa2_rxtx.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c
index dac086d..311861c 100644
--- a/drivers/net/dpaa2/dpaa2_rxtx.c
+++ b/drivers/net/dpaa2/dpaa2_rxtx.c
@@ -447,6 +447,12 @@ eth_copy_mbuf_to_fd(struct rte_mbuf *mbuf,
return 0;
}
+/* This function assumes that you will be keeping the same value for nb_pkts
^^^^^^^^^^
Ideally commit messages shouldn't have personifications 'you/your' etc
But, it is a trivial thing and I leave at your discretion.
+ * across calls per queue, if that is not the case, better use non-prefetch
+ * version of rx call.
+ * It will return the packets as request in the previous call without honoring
^^^^^^^^^
requested
[...]
Being very trivial comments, if you send the next version, please use:
Acked-by: Shreyansh Jain <shreyansh.j...@nxp.com>
