Re: [dpdk-dev] [PATCH v5 03/15] vhost: vring address setup for packed queues

[Maxime Coquelin]

On 06/29/2018 05:59 PM, Tiwei Bie wrote:

@@ -888,7 +914,8 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct 
VhostUserMsg *pmsg)
  static int
  vq_is_ready(struct vhost_virtqueue *vq)
  {
-       return vq && vq->desc && vq->avail && vq->used &&
+       return vq &&
+              (vq->desc_packed || (vq->desc && vq->avail && vq->used)) &&
               vq->kickfd != VIRTIO_UNINITIALIZED_EVENTFD &&
               vq->callfd != VIRTIO_UNINITIALIZED_EVENTFD;

It seems that the check is wrong here as desc_packed and desc are in a
union. We may have to check whether packed ring has been negotiated.