On 6/28/2018 4:19 AM, John Daley wrote: > From: Hyong Youb Kim <hyon...@cisco.com> > > Add a much-simplified handler that works when all offloads are > disabled, except mbuf fast free. When compared against the default > handler, under ideal conditions, cycles per packet drop by 60+%. > > By default, the driver tries to use the simple handler. Add a new > devarg (disable-simple-tx) to allow the user to force-disable this new > handler. > > The idea of using specialized/simplified handlers is from the Intel > and Mellanox drivers.
Existing usage does this automatically instead of having a devarg for it, the logic is use the simple handler when possible, if a feature requested that simple handler doesn't support switch to handler that supports it, you may consider same logic. <...> > @@ -42,6 +38,7 @@ static const struct rte_pci_id pci_id_enic_map[] = { > > #define ENIC_DEVARG_DISABLE_OVERLAY "disable-overlay" > #define ENIC_DEVARG_IG_VLAN_REWRITE "ig-vlan-rewrite" > +#define ENIC_DEVARG_DISABLE_SIMPLE_TX "disable-simple-tx" Same comment with previous one, please document new devargs.