On 26-Jun-18 2:09 AM, Kevin Wilson wrote:
Hi, Anatoly,
Thanks for these patches, good work.
Regarding "update-grub": IIRC, this is Ubuntu specific command (and
also used in Debian/Debian based flavors).
In Fedora (RedHat based) recent distros, you use grub2-mkconfig
instead (and there is no "update-grub", IIRC).
If this is true, I would consider adding a comment in the commit log
saying something like "it is for Ubuntu/Debian-based distros".
So maybe in the future someone will add the python code which detects
the OS (using lsb-release, etc) and, in case it is Fedora/RedHat
distro, the grub2-mkconfig util
will be invoked instead.
Regards,
KW
Hi Kevin,
It wasn't intended to be Ubuntu-specific - that's just what i developed
this patchset on :) Of course, if we get to a v1 stage, this will be
properly implemented to work on all distributions supported by DPDK.
Thanks for your feedback!
--
Thanks,
Anatoly
