Hi Thomas, On Tue, Jan 23, 2018 at 05:30:57PM +0100, Olivier Matz wrote: > Hi Thomas, > > On Fri, Dec 15, 2017 at 12:00:01PM +0100, Thomas Monjalon wrote: > > 15/12/2017 11:45, Olivier MATZ: > > > On Fri, Dec 15, 2017 at 11:32:12AM +0100, Thomas Monjalon wrote: > > > > 15/12/2017 11:25, Olivier MATZ: > > > > > On Fri, Dec 15, 2017 at 11:19:57AM +0100, Thomas Monjalon wrote: > > > > > > 14/12/2017 15:24, Olivier Matz: > > > > > > > @@ -157,6 +157,8 @@ install-sdk: > > > > > > > $(Q)cp -a $O/.config > > > > > > > $(DESTDIR)$(targetdir) > > > > > > > $(Q)cp -a $O/app/dpdk-pmdinfogen > > > > > > > $(DESTDIR)$(targetdir)/app > > > > > > > $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), > > > > > > > $(DESTDIR)$(targetdir)/include) > > > > > > > + $(Q)$(call rte_mkdir, > > > > > > > $(DESTDIR)$(libdir)) > > > > > > > + $(Q)cp -a $O/lib/* > > > > > > > $(DESTDIR)$(libdir) > > > > > > > $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), > > > > > > > $(DESTDIR)$(targetdir)/lib) > > > > > > > > > > > > The libs are already installed with "make install-runtime". > > > > > > Either we add a dependency between install-sdk and install-runtime, > > > > > > or we clearly document it. > > > > > > > > > > To me, libs are needed when installing the sdk (to compile against > > > > > them) > > > > > and when installing the runtime (to use them). > > > > > > > > > > Is it a problem to have it in both targets? > > > > > > > > Yes it is a problem because the general use is to call every targets, > > > > so the libs will be installed twice. Look at the global "install" > > > > target. > > > > > > > > Do you want to be able to install the SDK without the runtime? > > > > > > Hmm, you're right, installing the runtime instead of the sdk may be a > > > solution in our case. We don't need the bin, man, ... but it's probably > > > not an issue to have them anyway. > > > > > > So, to summarize: > > > install-runtime is the equivalent of the binary package > > > install-sdk is the equivalent of the -devel package > > > > Yes > > > > > And install-sdk depends on install-runtime, right? > > > > Depends logically, yes. But no dependence in the Makefile. > > Coming back on this topic, actually I think an issue remains with "make > install-sdk" which generates a bad symlink. > > # ls -l /tmp/toto/usr/local/share/dpdk/x86_64-native-linuxapp-gcc > drwxr-xr-x 2 root root 4096 Dec 11 11:49 app > lrwxrwxrwx 1 root root 21 Dec 11 11:49 include -> ../../../include/dpdk > lrwxrwxrwx 1 root root 12 Dec 11 11:49 lib -> ../../../lib # BAD LINK > > Would it make sense to remove the creation of the symlink? Something > like this: > > --- a/mk/rte.sdkinstall.mk > +++ b/mk/rte.sdkinstall.mk > @@ -157,7 +157,6 @@ install-sdk: > $(Q)cp -a $O/.config > $(DESTDIR)$(targetdir) > $(Q)cp -a $O/app/dpdk-pmdinfogen > $(DESTDIR)$(targetdir)/app > $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), > $(DESTDIR)$(targetdir)/include) > - $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), > $(DESTDIR)$(targetdir)/lib) > > install-doc: > ifneq ($(wildcard $O/doc/html),)
It looks we forgot this thread for a long time. Any opinon about it? Thanks Olivier
