On Mon, Jun 18, 2018 at 11:00:55AM +0100, Burakov, Anatoly wrote:
> On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote:
> > The doc says this function returns negative errno
> > on error, but it currently returns either -1 or
> > positive errno.
> >
> > It was incorrectly assumed that pthread_setname_np()
> > returns negative error numbers. It always returns
> > positive ones, so this patch negates its return value
> > before returning.
> >
> > While here, also ignore rte_thread_setname() failure
> > in rte_ctrl_thread_create() and print a debug message
> > instead.
> >
> > Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD")
> > Cc: thomas.monja...@6wind.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojac...@intel.com>
> > ---
>
> For patch contents,
>
> Acked-by: Anatoly Burakov <anatoly.bura...@intel.com>
>
> However, maybe this should be split in two patches.
Agree it should be split.
Reviewed-by: Olivier Matz <olivier.m...@6wind.com>
Out of curiosity, do you have a use-case where rte_thread_setname()
fails? The only reason I see is a too long name. Why this error
should be ignored?
