> -----Original Message----- > From: Burakov, Anatoly > Sent: Thursday, June 21, 2018 4:06 PM > To: Zhang, Qi Z <qi.z.zh...@intel.com>; tho...@monjalon.net > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org; > Richardson, Bruce <bruce.richard...@intel.com>; Yigit, Ferruh > <ferruh.yi...@intel.com>; Shelton, Benjamin H > <benjamin.h.shel...@intel.com>; Vangati, Narender > <narender.vang...@intel.com> > Subject: Re: [PATCH v2 03/22] ethdev: add function to release port in local > process > > On 21-Jun-18 3:00 AM, Qi Zhang wrote: > > Add driver API rte_eth_release_port_private to support the requirement > > that an ethdev only be released on secondary process, so only local > > state be set to unused , share data will not be reset so primary > > process can still use it. > > > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> > > --- > > <snip> > > > > > /** > > * @internal > > + * Release the specified ethdev port in local process, only set to > > +ethdev > > + * state to unused, but not reset share data since it assume other > > +process > > + * is still using it, typically it is called by secondary process. > > + * > > + * @param eth_dev > > + * The *eth_dev* pointer is the address of the *rte_eth_dev* structure. > > + * @return > > + * - 0 on success, negative on error > > + */ > > +int rte_eth_dev_release_port_private(struct rte_eth_dev *eth_dev); > > + > > As far as i can tell, even though the function is marked as internal, it > should still > be exported in the .map file (see rte_eth_dev_allocate() for example). > > Thomas and others, does this count as new API? Should this be marked as > __rte_experimental? Presumably, we guarantee ABI stability for internal > functions too, so my expectation would be yes.
Sorry, I not intent to mark this as experimental, I must forgot to remove this It should rte_eth_dev_attach/detach_private and rte_eth_dev_lock/unlock . I guess internal API is not necessary to have this. I will remove it in v3 Thanks Qi > > > +/** > > + * @internal > > * Release device queues and clear its configuration to force the user > > * application to reconfigure it. It is for internal use only. > > * > > > > > -- > Thanks, > Anatoly
