> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Monday, June 18, 2018 4:51 PM
> To: Zhang, Qi Z <qi.z.zh...@intel.com>; tho...@monjalon.net
> Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org;
> Richardson, Bruce <bruce.richard...@intel.com>; Yigit, Ferruh
> <ferruh.yi...@intel.com>; Shelton, Benjamin H
> <benjamin.h.shel...@intel.com>; Vangati, Narender
> <narender.vang...@intel.com>
> Subject: Re: [PATCH 06/22] ethdev: support attach or detach share device
> from secondary
>
>
> > + else
> > + return -1;
> > + do {
> > + ret = rte_mp_request_async(&mp_req, &ts, clb);
> > + } while (ret != 0 && rte_errno == EEXIST);
> > +
> > + if (ret)
> > + ethdev_log(ERR, "couldn't send async request\n");
> > + entry = find_request_by_id(req->id > + (void)entry;
>
> Why did you look up entry and then marked it as used without checking the
> return value? Leftover? Some code missing?
Some debug code forgot be removed :)
BTW, also accept all other comments
Thanks
Qi
