18/06/2018 08:04, Michał Krawczyk: > 2018-06-18 0:37 GMT+02:00 Thomas Monjalon <tho...@monjalon.net>: > > 07/06/2018 11:43, Michal Krawczyk: > >> ENA PMD is required to use librte_timer. The appropriate depndency must > >> be added ifin case the DPDK will be built as shared library. > >> > >> Signed-off-by: Michal Krawczyk <m...@semihalf.com> > >> --- > >> drivers/net/ena/Makefile | 1 + > >> mk/rte.app.mk | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile > >> index 43339f3b9..ff9ce315b 100644 > >> --- a/drivers/net/ena/Makefile > >> +++ b/drivers/net/ena/Makefile > >> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES) > >> LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > >> LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs > >> LDLIBS += -lrte_bus_pci > >> +LDLIBS += -lrte_timer > >> > >> include $(RTE_SDK)/mk/rte.lib.mk > >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk > >> index 1e32c83e7..c70bc254e 100644 > >> --- a/mk/rte.app.mk > >> +++ b/mk/rte.app.mk > >> @@ -60,6 +60,7 @@ endif > >> > >> _LDLIBS-y += --whole-archive > >> > >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer > > > > Why is it added in rte.app.mk? It is already there, few lines below. > > I think that's because it wasn't present on the version I was > preparing the patch (18.02) and I didn't notice that it was added > meantime when I was rebasing this patch. > > This patch is already merged to dpdk-next-net. Should I add a patch > that is reverting this change there?
I can remove it when pulling next-net today.
