Hi Bernard,
On Fri, Jun 15, 2018 at 09:32:02AM +0000, Iremonger, Bernard wrote:
> Hi Nelio,
>
>[...]
> > @@ -14927,6 +14930,81 @@ cmdline_parse_inst_t cmd_set_vxlan = {
> > },
> > };
> >
> > +/** Set VXLAN encapsulation details */
>
> VXLAN should be NVGRE.
>[...]
Right,
> > b/app/test-pmd/testpmd.c index 1c68c9d30..f54205949 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -408,6 +408,15 @@ struct vxlan_encap_conf vxlan_encap_conf = {
> > .eth_dst = "\xff\xff\xff\xff\xff\xff", };
> >
> > +struct nvgre_encap_conf nvgre_encap_conf = {
> > + .select_ipv4 = 1,
> > + .tni = "\x00\x00\x00",
> > + .ipv4_src = IPv4(127, 0, 0, 1),
> > + .ipv4_dst = IPv4(255, 255, 255, 255),
>
> Should there be .ipv6_src and .ipv6_dst here ?
>[...]
Yes indeed initialisation of IPv6 is missing.
> > +- ``nvgre_decap``: Performs a decapsulation action by stripping all
> > +headers of
> > + the VXLAN tunnel network overlay from the matched flow.
>
> VXLAN should be NVGRE.
>
>[...]
Here also,
I am will update it in a V2.
Thanks for you review,
--
Nélio Laranjeiro
6WIND
