Thanks for reviewing. Acked to all feedback
Thanks
Shally
>-----Original Message-----
>From: Kovacevic, Marko [mailto:marko.kovace...@intel.com]
>Sent: 14 June 2018 16:13
>To: Verma, Shally <shally.ve...@cavium.com>; De Lara Guarch, Pablo
><pablo.de.lara.gua...@intel.com>
>Cc: Trahe, Fiona <fiona.tr...@intel.com>; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
><narayanaprasad.athr...@cavium.com>; Sahu, Sunila <sunila.s...@cavium.com>;
>Gupta, Ashish <ashish.gu...@cavium.com>
>Subject: RE: [dpdk-dev] [PATCH v3 6/6] doc: add asym crypto in cryptodev
>programmer guide
>
>External Email
>
><...>
>
>> +params or prime modulus data i.e. immutable across data sets. Crypto
>> +sessions cache this immutable data in a optimal way for the underlying PMD
>> and this allows further acceleration of the offload of Crypto workloads.
>> +
>> +Like symmetric, the Crypto device framework provides APIs to allocate
>> +and initizalize asymmetric sessions for crypto devices, where sessions are
>
>Spelling initizalize/ initialize
>
>
>> mempool objects.
>> +It is the application's responsibility to create and manage the session
>> mempools.
>> +Application using both symmetric and asymmetric sessions should
>> +allocate and maintain different sessions pools for each type.
>> +
>
><...>
>
>> +Every operation must carry a valid session handle which further carries
>> +information on xform or xform-chain to be performed on op. Every xform
>> +type defines its own set of opertational params in their respective
>
>Spelling opertational/ operational
>
><...>
>
>> +
>> + /*
>> + * Dequeue the crypto operations until all the operations
>> + * are proccessed in the crypto device.
>> + */
>
>Spelling proccessed/ processed
>
>
><...>
>
>>
>> -Crypto Device API
>> -~~~~~~~~~~~~~~~~~
>> +Asymmetric Crypto Device API
>> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> The cryptodev Library API is described in the *DPDK API Reference*
>> document.
>
>Maybe try and have the DPDK API Reference as a clickable link so someone can
>just
>be brought straight to it. Maybe something like this
>
>`DPDK API Reference <http://dpdk.org/doc/api/>`_
>
