> Here is a patchset that reworks the log macro in e1000, ixgbe and i40e PMDs. > The idea behind this is to make it easier to debug some init failures and to > be > sure of the datapath selected in these PMDs (rx / tx handlers selection). > > The PMDs changes involve adding more debug messages in the default build. > A new eal option has been added to set the default log level, so that you can > render the eal a little less noisy. > > I did not change the default log level for now, as some eal log messages are > marked as DEBUG while being interesting (from my point of view). > I suppose we can change the default log level later once the eal has been > cleaned up. > > Changes since v2: > - just a respin with Jay comments in mind > * don't introduce \n in one commit then remove them > * indent only the impacted parts before removing \n (so split previous > patches) > * remove some "" garbage > > Changes since v1: > - continue clean up by always using PMD_*_LOG when logging something in > PMD (i.e. no more printf, RTE_LOG, DEBUGOUT) > - introduce PMD_DRV_LOG_RAW macro for use by shared driver code > - adopt 'second approach': no more \n in PMD_*_LOG callers. This means that we > will enforce a 'no \n' policy in logs for PMD. > > David Marchand (20): > ixgbe: use the right debug macro > ixgbe/base: add a raw macro for use by shared code > ixgbe: indent logs sections > ixgbe: clean log messages > ixgbe: always log init messages > ixgbe: add a message when forcing scatter mode > ixgbe: add log messages when rx bulk mode is not usable > i40e: use the right debug macro > i40e/base: add a raw macro for use by shared code > i40e: indent logs sections > i40e: clean log messages > i40e: always log init messages > i40e: add log messages when rx bulk mode is not usable > e1000: use the right debug macro > e1000/base: add a raw macro for use by shared code > e1000: indent logs sections > e1000: clean log messages > e1000: always log init messages > e1000: add a message when forcing scatter mode > eal: set log level from command line
Applied for version 1.8.0. Thanks -- Thomas
