On 6/7/2018 6:08 PM, Qi Zhang wrote:
Implemented the bus ops scan_one, besides this improve the scan
efficiency in hotplug case, it aslo avoid sync IPC invoke (which
                                 ^^^^
                                 also

happens in vdev->scan on secondary process). The benifit is it
                                                   ^^^^^^^
                                                   benefit

removes the potiential deadlock in the case when secondary process
              ^^^^^^^^^^
              potential

receive a request from primary process to attach a new device, since
vdev->scan will be invoked on mp thread itself at this case.
                                                 ^^^^^^^
                                                 in that


Besides the above spells, is it possible to re-write the commit?
You mention it "...improves the scan efficiency..." - how? Is that an implicit output of introducing the new scan_one for vdev?


Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>
---
  drivers/bus/vdev/vdev.c | 30 ++++++++++++++++++++++++++++++
  1 file changed, 30 insertions(+)

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 6139dd551..cdbd77df0 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -467,6 +467,35 @@ vdev_scan(void)
        return 0;
  }

[...]

Reply via email to