> On May 30, 2018, at 7:42 AM, David Marchand <david.march...@6wind.com> wrote:
>
> The callback should be invoked only for memory that has been registered
> in a device, hence, no need to track cleanup events if no device is
> present.
>
> Bugzilla-ID: 56
> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
>
> Signed-off-by: David Marchand <david.march...@6wind.com>
> ---
Good finding! Thank you so much for the patch.
Patch is good. Just to be sure, I've run traffic with testpmd and also run
multi-process test examples with traffic. It runs well.
Acked-by: Yongseok Koh <ys...@mellanox.com>
Thanks
> drivers/net/mlx5/mlx5.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index d77a20db4..601d03f71 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -138,6 +138,8 @@ mlx5_prepare_shared_data(void)
> LIST_INIT(&mlx5_shared_data->mem_event_cb_list);
> rte_rwlock_init(&mlx5_shared_data->mem_event_rwlock);
> }
> + rte_mem_event_callback_register("MLX5_MEM_EVENT_CB",
> + mlx5_mr_mem_event_cb, NULL);
> }
> rte_spinlock_unlock(&mlx5_shared_data_lock);
> }
> @@ -1460,8 +1462,6 @@ rte_mlx5_pmd_init(void)
> }
> mlx5_glue->fork_init();
> rte_pci_register(&mlx5_driver);
> - rte_mem_event_callback_register("MLX5_MEM_EVENT_CB",
> - mlx5_mr_mem_event_cb, NULL);
> }
>
> RTE_PMD_EXPORT_NAME(net_mlx5, __COUNTER__);
> --
> 2.11.0
>
