Sorry for having missed this patch during so long. 13/02/2018 11:48, Ferruh Yigit: > On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote: > > This script checks for the symbols specified in the map files against > > the symbols present in the map file directory. > > Currently, the script checks for map files in drivers and lib directory. > > > > Example: > > ./devtools/check-map.py > > > > The following symbols are unused : > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/... > > ['rte_dpaa_pool_table'] > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/... > > ['qbman_get_version', 'qbman_swp_send_multiple'] > > > > ... > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > +1 to improve our tools. > > Acked-by: Ferruh Yigit <ferruh.yi...@intel.com>
I agree we must have more tools. I think this check can be a lot simpler as a shell script, instead of Python. It does not need the list features of Python. I've run it and I see it does not catch symbols which are renamed with a prefix. Example: vfio_get_group_fd became rte_vfio_get_group_fd