On Fri, May 25, 2018 at 04:27:36PM +0800, Tiwei Bie wrote: > On Fri, May 25, 2018 at 09:20:08AM +0100, Ferruh Yigit wrote: > > On 5/25/2018 7:17 AM, Tiwei Bie wrote: > > > Signed-off-by: Tiwei Bie <tiwei....@intel.com> > > > > <...> > > > > > @@ -252,7 +252,7 @@ The corresponding callbacks are: > > > Example of using the vector version of the virtio poll mode driver in > > > ``testpmd``:: > > > > > > - testpmd -l 0-2 -n 4 -- -i --txqflags=0xF01 --rxq=1 --txq=1 > > > --nb-cores=1 > > > + testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 > > > --nb-cores=1 > > > > Thanks, I missed this one, there are a few occurrence of "--txqflags" [1]. > > > > Tiwei would you mind sending another patch for those? > > In below context "--txqflags" is not really focus, I think we can just > > remove it > > without replacing with "--tx-offloads" > > No problem. I will do it now. :) > > Best regards, > Tiwei Bie > > > > > Thanks, > > ferruh > > > > > > [1] > > doc/guides/contributing/documentation.rst: -- -i --txqflags=0x0 > > --enable-hw-vlan --enable-lro \ > > doc/guides/howto/vfd.rst: testpmd -l 0-7 -n 4 -- -i --txqflags=0 > > doc/guides/howto/vfd.rst: testpmd -l 0-7 -n 4 -- -i --txqflags=0
Hmm.. After a closer look, I think above two --txqflags can't be simply removed. In this guide, it needs to demonstrate these offloads, e.g. VLAN insertion: http://dpdk.org/browse/dpdk/tree/doc/guides/howto/vfd.rst?h=v18.05-rc5#n155 Right now, unfortunately I'm being busy with preparing a QEMU patch set which I need to get it done today. So I'm afraid that I don't have time to look into this today.. I'm Sorry.. :( Best regards, Tiwei Bie > > doc/guides/howto/virtio_user_as_exceptional_path.rst: -- -i > > --txqflags=0x0 --enable-lro \ > > doc/guides/howto/virtio_user_as_exceptional_path.rst: -- -i > > --txqflags=0x0 --enable-lro \ > > doc/guides/howto/virtio_user_for_container_networking.rst: -- -i > > --txqflags=0xf00 --disable-hw-vlan
