23/05/2018 12:09, Ferruh Yigit: > On 5/11/2018 12:58 AM, Thomas Monjalon wrote: > > A new hook function is added and called inside the PMDs at the end > > of the device probing: > > - in primary process, after allocating, init and config > > - in secondary process, after attaching and local init > > > > This new function is almost empty for now. > > It will be used later to add some post-initialization processing. > > > > For the PMDs calling the helpers rte_eth_dev_create() or > > rte_eth_dev_pci_generic_probe(), the hook rte_eth_dev_probing_finish() > > is called from here, and not in the PMD itself. > > > > Note that the helper rte_eth_dev_create() could be used more, > > especially for vdevs, avoiding some code duplication in PMDs. > > > > Cc: sta...@dpdk.org > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > Reviewed-by: Andrew Rybchenko <arybche...@solarflare.com> > > Reviewed-by: Stephen Hemminger <step...@networkplumber.org> > > Hi Thomas, > > This change forces PMDs to call rte_eth_dev_probing_finish() to have them in > proper state. But this requirement is not very clear and documented, it is > easy > to miss! > > Does it make sense update release notes and highlight to say all PMDs should > call rte_eth_dev_probing_finish(), directly or via helper functions?
You want to make PMD developers aware of this change? It's not a new feature, and not an API change, so I don't know where to write it.
