I completely missed this last bit in the NFP driver. I will send a patch today.
By the way, will it go into 18.05? I ask because I have another patch fixing a problem which would be good to have in 18.05 as well. On Mon, May 21, 2018 at 1:38 PM, Ferruh Yigit <ferruh.yi...@intel.com> wrote: > On 5/11/2018 11:45 AM, Ferruh Yigit wrote: > > Some PMDs are still using old offloading API related variables, thanks > to Andrew > > for reporting it. > > > > Maintainers of related PMDs are cc'ed. > > Please check following list and provide a fix ASAP for it, thanks. > > > > > > # git grep header_split drivers/ > > drivers/net/i40e/i40e_rxtx_vec_common.h: if > (rxmode->header_split == 1) > > > > # git grep hw_vlan_filter drivers/ > > drivers/net/i40e/i40e_vf_representor.c: if > > (ethdev->data->dev_conf.rxmode.hw_vlan_filter) > > drivers/net/vhost/rte_eth_vhost.c: if (rxmode->hw_vlan_filter) > > > > # git grep hw_vlan_strip drivers/ > > drivers/net/dpaa2/dpaa2_rxtx.c: if > > (dev->data->dev_conf.rxmode.hw_vlan_strip) > > drivers/net/i40e/i40e_vf_representor.c: if > > (ethdev->data->dev_conf.rxmode.hw_vlan_strip)T > > drivers/net/vhost/rte_eth_vhost.c: internal->vlan_strip = > > rxmode->hw_vlan_strip; > > > > # git grep hw_vlan_extend drivers/ > > drivers/net/i40e/i40e_rxtx_vec_common.h: if > (rxmode->hw_vlan_extend == 1) > > > > # git grep hw_strip_crc drivers/ > > drivers/net/nfp/nfp_net.c: rxq->crc_len = (uint8_t) > > ((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0 > > drivers/net/sfc/sfc_rx.c: rxmode->hw_strip_crc = 1; > > > > Reminder of this one. >
