21/05/2018 14:58, Radu Nicolau:
>
> On 5/21/2018 1:30 PM, Thomas Monjalon wrote:
> > 21/05/2018 13:35, Radu Nicolau:
> >> Fixes: af75078fece3 ("first public release")
> >> Cc: sta...@dpdk.org
> >>
> >> Signed-off-by: Radu Nicolau <radu.nico...@intel.com>
> >> ---
> >> @@ -34,7 +34,8 @@ test_panic(void)
> >> printf("Fork Failed\n");
> >> return -1;
> >> }
> >> - wait(&status);
> >> + sleep(1);
> >> + waitpid(pid, &status, WNOHANG);
> > Please give an explanation why you are adding this sleep.
> >
> To give a chance to the child process to complete before calling waitpid.
One second in an unit test is a lot.
When I was asking for explanation, I mean usual explanations in commit message:
- what is the issue
- what is the root cause
- what is the reasoning behind the fix
