Hi Pablo, thanks for the information update. I am ok with this patch, except for one cosmetic change shared inline to previous email otherwise ACK from segmentation.
> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, May 18, 2018 6:50 PM > To: Doherty, Declan <declan.dohe...@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> > Subject: [dpdk-dev] [PATCH] cryptodev: extend feature flags description > > Extend the description of cryptodev feature flags, adding extra information. > > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com> > --- > lib/librte_cryptodev/rte_cryptodev.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_cryptodev/rte_cryptodev.h > b/lib/librte_cryptodev/rte_cryptodev.h > index 261a359dc..eeb51afac 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -373,7 +373,9 @@ struct rte_cryptodev_info { > uint8_t driver_id; /**< Driver identifier */ > struct rte_pci_device *pci_dev; /**< PCI information. */ > > - uint64_t feature_flags; /**< Feature flags */ > + uint64_t feature_flags; > + /**< Feature flags exposes for the given device its > + * HW/SW offload features. */ Can we slightly rephrase as "exposes offload HW|SW features for the given device" as "feature flags" will be header? > > const struct rte_cryptodev_capabilities *capabilities; > /**< Array of devices supported capabilities */ > -- > 2.17.0
